Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue time marshal #3515

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Conversation

shuofan
Copy link
Contributor

@shuofan shuofan commented Dec 28, 2021

What type of this PR

bugfix

What this PR does / why we need it:

Fix issue time marshal

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.5 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn December 28, 2021 02:54
@Effet
Copy link
Member

Effet commented Dec 28, 2021

/approve

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #3515 (4b3dd50) into master (6a430b4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3515      +/-   ##
==========================================
- Coverage   18.30%   18.28%   -0.02%     
==========================================
  Files        1414     1414              
  Lines      145417   145419       +2     
==========================================
- Hits        26618    26596      -22     
- Misses     116121   116149      +28     
+ Partials     2678     2674       -4     
Impacted Files Coverage Δ
apistructs/issue.go 9.65% <0.00%> (-0.05%) ⬇️
pkg/mock/mock.go 42.42% <0.00%> (-3.04%) ⬇️
modules/dop/services/issue/issue.go 4.30% <0.00%> (-1.82%) ⬇️

@erda-bot erda-bot merged commit fd1e4be into erda-project:master Dec 28, 2021
@shuofan
Copy link
Contributor Author

shuofan commented Dec 28, 2021

/cherry-pick release/1.5

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Dec 28, 2021
@Effet Effet deleted the bug/issue-update branch December 28, 2021 05:32
Effet pushed a commit that referenced this pull request Dec 28, 2021
Co-authored-by: shuofan <fanshuo2015@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants